x/market/client/cli/lease.go (1)

63-66: Misleading help text: “Query order” for a lease getter.

Minor polish for UX.

Apply:

-		Short: "Query order",
+		Short: "Query lease",

x/market/client/cli/bid.go (1)

63-66: Misleading help text: “Query order” for a bid getter.

Apply:

-		Short: "Query order",
+		Short: "Query bid",

x/market/keeper/grpc_query.go (4)

33-41: Defensively reject requests that set both Key and Offset.

Client fixes help, but gRPC should also enforce mutual exclusivity to protect server invariants.

Apply this diff:

 if req.Pagination == nil {
   req.Pagination = &sdkquery.PageRequest{}
 } else if req.Pagination != nil && req.Pagination.Offset > 0 && req.Filters.State == "" {
   return nil, status.Error(codes.InvalidArgument, "invalid request parameters. if offset is set, filter.state must be provided")
 }
+// Defensive: page key and numeric offset are mutually exclusive
+if len(req.Pagination.Key) > 0 && req.Pagination.Offset > 0 {
+  return nil, status.Error(codes.InvalidArgument, "invalid request parameters. set either page key or offset, not both")
+}

---

189-196: Reverse-search decode fix (unsolicited[0]) is correct.

This removes the off‑by‑index bug and matches the encoder which sets a single flag byte.

For readability, consider a named constant:

+const unsolicitedReverseSearch byte = 1
@@
-    if unsolicited[0] == 1 {
+    if unsolicited[0] == unsolicitedReverseSearch {
       reverseSearch = true
     }

---

164-172: Add the same key/offset mutual‑exclusion guard for Bids.

Mirror the Orders validation to block ambiguous pagination requests.

Apply this diff:

 if req.Pagination == nil {
   req.Pagination = &sdkquery.PageRequest{}
 } else if req.Pagination != nil && req.Pagination.Offset > 0 && req.Filters.State == "" {
   return nil, status.Error(codes.InvalidArgument, "invalid request parameters. if offset is set, filter.state must be provided")
 }
+if len(req.Pagination.Key) > 0 && req.Pagination.Offset > 0 {
+  return nil, status.Error(codes.InvalidArgument, "invalid request parameters. set either page key or offset, not both")
+}

---

318-326: Also enforce key/offset mutual exclusivity for Leases.

Keeps all three query handlers consistent and resilient against malformed clients.

Apply this diff:

 if req.Pagination == nil {
   req.Pagination = &sdkquery.PageRequest{}
 } else if req.Pagination != nil && req.Pagination.Offset > 0 && req.Filters.State == "" {
   return nil, status.Error(codes.InvalidArgument, "invalid request parameters. if offset is set, filter.state must be provided")
 }
+if len(req.Pagination.Key) > 0 && req.Pagination.Offset > 0 {
+  return nil, status.Error(codes.InvalidArgument, "invalid request parameters. set either page key or offset, not both")
+}

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro